Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve debug log filtering #12763

Merged
merged 1 commit into from Apr 6, 2023
Merged

chore: improve debug log filtering #12763

merged 1 commit into from Apr 6, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 6, 2023

Description

When I start Vite with vite --debug plugin-transform --filter import-analysis, it doesn't really work because the filter is applied to the first arg passed to debug() only. So given this debug log:

vite:plugin-transform 2.71ms vite:import-analysis src/app.ts +16ms

The first arg is 2.71ms which isn't really useful for filtering. This PR checks all args for filtering instead.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label Apr 6, 2023
@stackblitz
Copy link

stackblitz bot commented Apr 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit da1cb02 into main Apr 6, 2023
11 checks passed
@patak-dev patak-dev deleted the improve-log-filter branch April 6, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants